Add unit tests for fit_ellipse_to_points function Resolves #36 Adds…#61
Add unit tests for fit_ellipse_to_points function Resolves #36 Adds…#61AdityaGupta716 wants to merge 2 commits intoneuroinformatics-unit:mainfrom
Conversation
…matics-unit#36 Adds comprehensive tests to verify correct ellipse center estimation. This file contains unit tests for the fit_ellipse_to_points function, verifying its behavior with various point patterns, including circular and elliptical arrangements, as well as edge cases with insufficient points and NaN values.
|
Hi @AdityaGupta716, as said in the issue #36, this PR is a duplicate of #60 and you might want to describe how it covers the same edge cases, and/or join efforts with @AlgoFoe |
|
@lauraporta i can merge the useful parts of #60 into this PR instead of duplicating and reuse their noisy ellipse+circle tests and keep my edge case test(min points , few points error,NaN handling ) in the same file and will update when done |
|
@lauraporta i am done with the changes it replaces the old minimal tests for fit ellipse to points with a much more readable suite that actually tests how the function is used in practice it generates realistic synthetic ellipse including rotated and noisy ones and checks that the fitted ellipse recovers the correct center eccentricity and orientation across a range if configuration not just one or two and also keeps behaviour from the earlier tests NaN AND VALUE ERROR |
|
Hi @AdityaGupta716, alright thank you, I will review your PR in the coming weeks! |
2 participants
Description
This PR adds comprehensive unit tests for the
fit_ellipse_to_pointsfunction in the derotation module.What is this PR?
Testing
The tests verify:
All tests use synthetic geometric patterns with known centers to verify accuracy within specified tolerances.
Related Issues
Resolves #36